Rename examples/ to samples/ - #8
Merged
Merged
Conversation
examples/ has a reserved meaning in Cargo -- it auto-discovers .rs files placed directly under it as example binary targets (cargo run --example). This directory only ever held sample RAW photo files for the README walkthrough, no Rust code, so rename it to samples/ to avoid the naming collision. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKmYgyL2p8FVFu9Wx13t4K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/is a Cargo-reserved directory name:.rsfiles placed directly under it are auto-discovered as example binary targets (cargo run --example). This repo'sexamples/held only sample RAW photo files + an attribution doc for the README walkthrough, no Rust code — renamed tosamples/to avoid the collision.Cargo.toml'sexcludeglobs,.gitignore.Test plan
grep -rn "examples/raw"across.md/.toml/.ymlfiles returns nothing.cargo package --liststill correctly excludes the sample RAW binaries from the published crate (samples/raw/ATTRIBUTION.mdincluded, the.CR2/.NEF/.RW2/.ARWfiles excluded).🤖 Generated with Claude Code
https://claude.ai/code/session_01AKmYgyL2p8FVFu9Wx13t4K