Skip to content

Merge 1.4.3#349

Merged
valentinfrlch merged 63 commits into
provider-settingsfrom
main
May 15, 2025
Merged

Merge 1.4.3#349
valentinfrlch merged 63 commits into
provider-settingsfrom
main

Conversation

@valentinfrlch

Copy link
Copy Markdown
Owner

No description provided.

LeeTheBuilder and others added 30 commits March 6, 2025 10:21
1. saves event to timeline no matter how important it it.
2. start analysis in parallel, to avoid missing initial clips.
…xtract only iframes and keep only max_frames in memory,

Expose images in original size,
Send images in frame order instead of SSIM score order
Optimise Event Processing: First Frame as Key Frame, Improved Memory Prompt, and Gemini Error catching
TheRealFalseReality and others added 20 commits April 8, 2025 20:08
Moved Live Feed to Initial notification when selected and updated notification is always snapshot of event
Removed Android Instant Snapshot requirement and should now send a snapshot of the first camera when using multiple camera entities
Fix remember service call crash with time conversion utility
- Bump version number
- remove default model
Add french translation
Fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Bump version number
- Update bento board
Update blueprint to v1.4.3 (from beta)
@github-advanced-security

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@valentinfrlch valentinfrlch requested a review from Copilot May 15, 2025 19:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the 1.4.3 release by updating translation files for multiple languages, refining provider and media handling implementations, and performing minor cleanups in configuration and documentation.

  • Updated translations for Swedish, Slovak, French, and Chinese
  • Improved provider defaults and image handling for media frames
  • Removed unused cleanup service and updated versioning in manifest and README

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
custom_components/llmvision/translations/*.json Added translations for SV, SK, FR, and CN
custom_components/llmvision/services.yaml Removed unused cleanup service
custom_components/llmvision/providers.py Updated provider constants and defaults (e.g., Google)
custom_components/llmvision/memory.py Added await img.load for improved image handling
custom_components/llmvision/media_handlers.py Refactored frame sorting and image exposure logic
custom_components/llmvision/manifest.json Updated version to 1.4.3
custom_components/llmvision/icons.json Removed cleanup icon entry
custom_components/llmvision/const.py Updated default prompts with minor text fixes
custom_components/llmvision/calendar.py Adjusted image deletion and event migration logic
custom_components/llmvision/init.py Added time conversion functions and cleanup triggering
README.md Updated version badge to 1.4.3
.github/ISSUE_TEMPLATE/*.md & config.yml Removed obsolete feature request template and updated links
Comments suppressed due to low confidence (2)

custom_components/llmvision/media_handlers.py:452

  • The standard library bisect.insort does not support a 'key' parameter; consider inserting the tuple without a key and then sorting the list, or use an alternative method to maintain sorted order.
insort(frames, (previous_frame_path, score), key=lambda x: x[1])

custom_components/llmvision/const.py:73

  • Typo detected: 'chaaracters' should be corrected to 'characters'.
DEFAULT_SYSTEM_PROMPT = "Your task is to analyze a series of images and provide a concise event description ... within 255 chaaracters."

Comment thread custom_components/llmvision/media_handlers.py Outdated
Remove duplicate sort

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@valentinfrlch valentinfrlch merged commit bfd801c into provider-settings May 15, 2025
10 checks passed
@tabascoz

Copy link
Copy Markdown

Hi, having some issue with this commit:

logger: homeassistant.setup
Source: setup.py:344
First occurred: 10:39:14 PM (1 occurrence)
Last logged: 10:39:14 PM
Setup failed for custom integration 'llmvision': Unable to import component: cannot import name 'CONF_DEFAULT_TOP_P' from 'custom_components.llmvision.const' (/etc/homeassistant/custom_components/llmvision/const.py)

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/homeassistant/loader.py", line 993, in async_get_component
    comp = await self.hass.async_add_import_executor_job(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        self._get_component, True
        ^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/python3.13/concurrent/futures/thread.py", line 59, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.13/site-packages/homeassistant/loader.py", line 1053, in _get_component
    ComponentProtocol, importlib.import_module(self.pkg_path)
                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/homeassistant/util/loop.py", line 201, in protected_loop_func
    return func(*args, **kwargs)
  File "/usr/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1026, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/etc/homeassistant/custom_components/llmvision/__init__.py", line 4, in <module>
    from .const import (
    ...<43 lines>...
    )
ImportError: cannot import name 'CONF_DEFAULT_TOP_P' from 'custom_components.llmvision.const' (/etc/homeassistant/custom_components/llmvision/const.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/homeassistant/setup.py", line 344, in _async_setup_component
    component = await integration.async_get_component()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/homeassistant/loader.py", line 1013, in async_get_component
    self._component_future.result()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/homeassistant/loader.py", line 1005, in async_get_component
    comp = self._get_component()
  File "/usr/lib/python3.13/site-packages/homeassistant/loader.py", line 1053, in _get_component
    ComponentProtocol, importlib.import_module(self.pkg_path)
                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/homeassistant/util/loop.py", line 201, in protected_loop_func
    return func(*args, **kwargs)
  File "/usr/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1026, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/etc/homeassistant/custom_components/llmvision/__init__.py", line 4, in <module>
    from .const import (
    ...<43 lines>...
    )
ImportError: cannot import name 'CONF_DEFAULT_TOP_P' from 'custom_components.llmvision.const' (/etc/homeassistant/custom_components/llmvision/const.py)

@valentinfrlch

valentinfrlch commented May 16, 2025

Copy link
Copy Markdown
Owner Author

Yeah me too... But that's because provider-settings wasn't working before either. It's still actively in development and not ready for production or testing.

I have fixed the imports. Will push soon.

@tabascoz

Copy link
Copy Markdown

Thanks - bad habit of following dev :)

@valentinfrlch

Copy link
Copy Markdown
Owner Author

No worries! I realized I messed up the manual merge yesterday thanks to you. So the main branch might have some errors as well now...
Since we're using releases it shouldn't be a problem (as long as no one manually clones the main branch). Still, I need to fix this asap. So yeah, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.