Merge 1.4.3#349
Conversation
1. saves event to timeline no matter how important it it. 2. start analysis in parallel, to avoid missing initial clips.
…xtract only iframes and keep only max_frames in memory, Expose images in original size, Send images in frame order instead of SSIM score order
Enhance video processing
Optimise Event Processing: First Frame as Key Frame, Improved Memory Prompt, and Gemini Error catching
Add Slovak translation.
Moved Live Feed to Initial notification when selected and updated notification is always snapshot of event
Removed Android Instant Snapshot requirement and should now send a snapshot of the first camera when using multiple camera entities
Some Upgrades to Blueprint
Fix remember service call crash with time conversion utility
- Bump version number - remove default model
Add french translation
Create fr.json
Fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
V1.4.3 beta
- Bump version number - Update bento board
Update blueprint to v1.4.3 (from beta)
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 1.4.3 release by updating translation files for multiple languages, refining provider and media handling implementations, and performing minor cleanups in configuration and documentation.
- Updated translations for Swedish, Slovak, French, and Chinese
- Improved provider defaults and image handling for media frames
- Removed unused cleanup service and updated versioning in manifest and README
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| custom_components/llmvision/translations/*.json | Added translations for SV, SK, FR, and CN |
| custom_components/llmvision/services.yaml | Removed unused cleanup service |
| custom_components/llmvision/providers.py | Updated provider constants and defaults (e.g., Google) |
| custom_components/llmvision/memory.py | Added await img.load for improved image handling |
| custom_components/llmvision/media_handlers.py | Refactored frame sorting and image exposure logic |
| custom_components/llmvision/manifest.json | Updated version to 1.4.3 |
| custom_components/llmvision/icons.json | Removed cleanup icon entry |
| custom_components/llmvision/const.py | Updated default prompts with minor text fixes |
| custom_components/llmvision/calendar.py | Adjusted image deletion and event migration logic |
| custom_components/llmvision/init.py | Added time conversion functions and cleanup triggering |
| README.md | Updated version badge to 1.4.3 |
| .github/ISSUE_TEMPLATE/*.md & config.yml | Removed obsolete feature request template and updated links |
Comments suppressed due to low confidence (2)
custom_components/llmvision/media_handlers.py:452
- The standard library bisect.insort does not support a 'key' parameter; consider inserting the tuple without a key and then sorting the list, or use an alternative method to maintain sorted order.
insort(frames, (previous_frame_path, score), key=lambda x: x[1])
custom_components/llmvision/const.py:73
- Typo detected: 'chaaracters' should be corrected to 'characters'.
DEFAULT_SYSTEM_PROMPT = "Your task is to analyze a series of images and provide a concise event description ... within 255 chaaracters."
Remove duplicate sort Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hi, having some issue with this commit: |
|
Yeah me too... But that's because I have fixed the imports. Will push soon. |
|
Thanks - bad habit of following dev :) |
|
No worries! I realized I messed up the manual merge yesterday thanks to you. So the |
No description provided.