Skip to content

Support TLS with valkeys:// connection string - #33

Open
joksnet wants to merge 1 commit into
valkey-io:mainfrom
joksnet:patch-1
Open

joksnet wants to merge 1 commit into
valkey-io:mainfrom
joksnet:patch-1

Conversation

@joksnet

@joksnet joksnet commented May 25, 2025

Copy link
Copy Markdown

First small step.

Signed-off-by: Juan M Martínez <joksnet@gmail.com>
@mcollina

Copy link
Copy Markdown
Collaborator

Thanks for opening a PR! Can you please add a unit test?

@mcollina

Copy link
Copy Markdown
Collaborator

Are you still interested in updating this PR? If so, please rebase it onto the current main and add the requested URL parsing tests. The update should handle both valkey:// and valkeys:// consistently, including credentials, ports, trailing slashes, and database paths such as /4; changing only TLS detection leaves database paths parsed as Unix socket paths.

@mcollina

Copy link
Copy Markdown
Collaborator

I have opened #74 with complete valkey:// and valkeys:// parsing, TLS handling, database-path support, and regression tests. It incorporates the change proposed here along with the additional parser work and coverage requested in review, so this PR is now superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants