Conversation
Adapt the sharded subscriber-group architecture and lifecycle work from redis/ioredis PRs #1956, #2013, #2043, #2060, and #2090. Co-authored-by: David Maier <60782329+dmaier-redislabs@users.noreply.github.com> Co-authored-by: Tihomir Krasimirov Mateev <tihomir.mateev@redis.com> Co-authored-by: Pavel Pashov <60297174+PavelPashov@users.noreply.github.com> Co-authored-by: Hristo Temelski <hristo.temelski@redis.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix/p1-13-sharded-pubsub
branch
from
July 14, 2026 07:18
26e269e to
e840c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSUBSCRIBEandSUNSUBSCRIBEto the primary that owns the channel slotMOVEDresponses, reconnects, and slot migrationSUNSUBSCRIBECloses #13.
Integration coverage
Adds a dedicated
test-valkey-clusterGitHub Actions job. It starts three Valkey primaries and three replicas from the pinnedvalkey/valkey:8.0.9image, then verifies realSSUBSCRIBE/SPUBLISHdelivery for channels owned by different primaries.The same test runs locally with:
Validation
npm run buildnpm run test:tsdnpm run lint: no errors; 12 pre-existing warningsUpstream attribution
ClusterSubscriberGroupandShardedSubscriberadapt work from redis/ioredis PRs #1956, #2013, #2043, #2060, and #2090.The implementation commit includes
Co-authored-byattribution for David Maier, Tihomir Krasimirov Mateev, Pavel Pashov, and Hristo Temelski.