Skip to content

Bump valkey-glide to 2.5.2 - #106

Merged
jeremyprime merged 5 commits into
valkey-io:mainfrom
jeremyprime:bump-glide-2.5.2
Sep 3, 2026
Merged

jeremyprime merged 5 commits into
valkey-io:mainfrom
jeremyprime:bump-glide-2.5.2

Conversation

@jeremyprime

@jeremyprime jeremyprime commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bump Valkey GLIDE version to 2.5.2.

Closes #105

Implementation

  • Bump valkey-glide from 2.4.2 to 2.5.2
  • Fix cluster SAVE failing with "No multi value stored" as 2.5.x returns SAVE as a single value rather than a map
  • Adopt GLIDE's clientInfoTag (new in 2.5.x) for framework attribution instead of overriding libName, changing the reported lib-name from GlideSpringDataValkey to GlideJava(SpringDataValkey)

Testing

All unit tests, examples, and manual tests pass.

Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: b57ae754-8707-47e4-85c5-f7579e48a128

📥 Commits

Reviewing files that changed from the base of the PR and between d40067a and 85e88cb.

📒 Files selected for processing (2)
  • docs/src/content/docs/valkey/drivers.md
  • spring-data-valkey/src/main/java/io/valkey/springframework/data/valkey/connection/valkeyglide/ValkeyGlideClusterServerCommands.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR upgrades Valkey-Glide from 2.4.2 to 2.5.2. It updates client identification, cluster response handling, integration test assertions, and driver documentation.

Changes

Valkey-Glide 2.5.2 compatibility

Layer / File(s) Summary
Client identity and version configuration
pom.xml, spring-data-valkey/src/main/java/io/valkey/springframework/data/valkey/connection/valkeyglide/*Adapter.java, spring-data-valkey/src/test/java/io/valkey/springframework/data/valkey/connection/valkeyglide/*ServerCommandsIntegrationTests.java, docs/src/content/docs/valkey/drivers.md
The project uses Valkey-Glide 2.5.2. Both adapters set clientInfoTag("SpringDataValkey"). Integration tests check the updated lib-name format. Driver examples use ${version} placeholders.
Cluster response handling
spring-data-valkey/src/main/java/io/valkey/springframework/data/valkey/connection/valkeyglide/ClusterGlideClientAdapter.java, spring-data-valkey/src/main/java/io/valkey/springframework/data/valkey/connection/valkeyglide/ValkeyGlideClusterServerCommands.java
Cluster command handling preserves map responses for BGREWRITEAOF and BGSAVE. SAVE accepts GLIDE 2.5.x single-value aggregation. Custom command aggregation now requires multi-value data.

Merge Risk: ⚪ Minimal · up to 85e88

This updates GLIDE compatibility, client attribution, cluster command response handling, and dependency documentation. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue #105 by replacing the GLIDE lib-name override with clientInfoTag and updating tests for the new GlideJava(SpringDataValkey) format.
Out of Scope Changes check ✅ Passed The dependency update, compatibility fixes, client attribution changes, tests, and documentation updates support the stated pull request objectives and issue #105.
Title check ✅ Passed The title clearly and concisely identifies the primary change: upgrading Valkey GLIDE to version 2.5.2.
Description check ✅ Passed The description is directly related to the changeset and summarizes the dependency upgrade, cluster command fixes, client attribution change, and testing.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xShinnRyuu xShinnRyuu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring the nit comments and offline concerns

Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
@jeremyprime
jeremyprime merged commit 427208e into valkey-io:main Sep 3, 2026
23 checks passed
@jeremyprime
jeremyprime deleted the bump-glide-2.5.2 branch September 3, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move GLIDE lib-name override to clientInfoTag

3 participants