Bump valkey-glide to 2.5.2 - #106
Conversation
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR upgrades Valkey-Glide from 2.4.2 to 2.5.2. It updates client identification, cluster response handling, integration test assertions, and driver documentation. ChangesValkey-Glide 2.5.2 compatibility
Merge Risk: ⚪ Minimal · up to This updates GLIDE compatibility, client attribution, cluster command response handling, and dependency documentation. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xShinnRyuu
left a comment
There was a problem hiding this comment.
LGTM barring the nit comments and offline concerns
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Summary
Bump Valkey GLIDE version to 2.5.2.
Closes #105
Implementation
SAVEfailing with "No multi value stored" as 2.5.x returnsSAVEas a single value rather than a mapclientInfoTag(new in 2.5.x) for framework attribution instead of overridinglibName, changing the reported lib-name fromGlideSpringDataValkeytoGlideJava(SpringDataValkey)Testing
All unit tests, examples, and manual tests pass.