Conversation
Collaborator
|
Thanks for raising this @Echways. Unfortunately, the |
Collaborator
|
@Echways I am going to close this pull request. Please feel free to re-open and continue the conversation if I've missed anything! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the Valkey 8.2 stream trim modes
DELREFandACKEDin the C# client.Issue Link
This pull request is linked to issue: Closes #311
Features and Behaviour Changes
DeleteReferencesandAcknowledgedvalues toStreamTrimMode.StreamTrimOptionsto emitDELREFandACKEDfor stream trimming.XTRIMcommand argument construction.KeepReferencesbehavior unchanged and does not emitKEEPREF, preserving backward compatibility with older servers.Implementation
DELREFandACKED.StreamTrimModeExtensions.ToKeyword()helper to centralize mapping fromStreamTrimModeto command keywords.StreamTrimOptions.ToArgs()to append the trim mode keyword afterLIMIT, matching the command syntax.Request.StreamTrimAsync()to accept aStreamTrimModeand include the corresponding keyword in generatedXTRIMarguments.DELREF,ACKED, default behavior, andLIMITordering.Limitations
DELREFandACKEDrequire Valkey 8.2 or later. The client does not perform a local server-version check; unsupported servers will return the server-side command error.KeepReferencesremains the default mode and is not emitted asKEEPREFto preserve existing behavior and compatibility with older servers.Testing
Updated unit tests for stream command argument generation.
Ran:
Related Issues
Closes #311
Checklist
CHANGELOG.md,README.md,DEVELOPER.md, and other documentation files are updated.mainor releasemain, squash otherwise.