Skip to content

Investigate why command_with_route_info() isn't equivalent to command() #289

Description

@Aryex

send_command uses two FFI paths today: Bindings.command for calls with no route, and Bindings.command_with_route_info only when an explicit route is given (lib/valkey.rb:458-483).

The plan was to unify on command_with_route_info (passing route_info = NULL for the no-route case) and drop the legacy command path. But during testing the two weren't equivalent in some cases, so we kept command for unrouted calls for now (see the note at lib/valkey.rb:473).

We suspect a bug in command_with_route_info, but they share the same code path on the FFI layer so unclear if this is an issue.

Goal

  1. Find a reproducible case where routing a command through command_with_route_info (no route) behaves differently from command.
  2. Fix the issue if appropriate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions