fix(ci): build against glibc 2.17 and updated readme requirements. - #232
Merged
Merged
Conversation
Signed-off-by: Alex Le <alex.le@improving.com>
Signed-off-by: Alex Le <alex.le@improving.com>
Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
marked this pull request as ready for review
August 5, 2026 19:31
Closed
yipin-chen
approved these changes
Aug 6, 2026
Aryex
added a commit
that referenced
this pull request
Aug 14, 2026
) * fix: workflows now correctly builds against glibc 2.17 Signed-off-by: Alex Le <alex.le@improving.com> * updated macos docs Signed-off-by: Alex Le <alex.le@improving.com> * docs: removed JRuby support Signed-off-by: Alex Le <alex.le@improving.com> --------- Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
added a commit
that referenced
this pull request
Aug 14, 2026
) * fix: workflows now correctly builds against glibc 2.17 Signed-off-by: Alex Le <alex.le@improving.com> * updated macos docs Signed-off-by: Alex Le <alex.le@improving.com> * docs: removed JRuby support Signed-off-by: Alex Le <alex.le@improving.com> --------- Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
added a commit
that referenced
this pull request
Aug 14, 2026
) * fix: workflows now correctly builds against glibc 2.17 Signed-off-by: Alex Le <alex.le@improving.com> * updated macos docs Signed-off-by: Alex Le <alex.le@improving.com> * docs: removed JRuby support Signed-off-by: Alex Le <alex.le@improving.com> --------- Signed-off-by: Alex Le <alex.le@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the published gem's prebuilt
libglide_ffi.soto compile against glibc 2.17. We also updated the Readme to reflect the current Ruby version support.README / documentation changes
This PR also corrects the System Requirements section, which previously claimed platforms that were never tested and, in some cases, cannot work.
Notably, we removed the JRuby support from documentations. Added #235 as a followup to verify our support level.
Issue
Close #223
Changes
Build the two
linux-gnutargets withcargo zigbuild --target <triple>.2.17to pin glibc to 2.17. This matches how the upstream Java client builds its native artifacts.github/actions/install-zigbuildinstalls pinned zig + cargo-zigbuild (versions kept internal, not exposed as inputs). Used by bothcd.ymlandci.yml.--targetmoves cargo output totarget/<triple>/release/.aarch64-apple-darwinships).Verification
Build: CD run on this branch built both
linux-gnutargets successfully —aws-lc-sys/ringcompile cleanly throughzig cc.glibc floor:
objdump -Ton the shippedlibglide_ffi.sotops out atGLIBC_2.17on both x86_64 and aarch64. Pre-fix baseline wasGLIBC_2.39.Functional (native, not emulated): the fixed gem was installed and exercised on a native x86_64 EC2 instance (glibc 2.31) inside Docker containers for both distros from the issue report:
require+ PING/SET/GETGLIBC_2.17GLIBC_2.17The native run confirms the fix end-to-end for the exact environments reported in #223. (Ubuntu 20.04's stock Ruby 2.7.0 cannot install the gem — the
ffi ~> 1.17dependency requires Ruby ≥ 3.0 — but that is a separate, non-glibc packaging constraint, not a regression of this fix; verified with Ruby 3.2 in the same glibc-2.31 container.)