Remove dead duplicate Verify() from ft_search_parser

[allenss-amazon]

Deletes the unreachable Verify() in the anonymous namespace of src/commands/ft_search_parser.cc.

History:

• Fix Aggregation processing of LOAD clause and validation of vector query parameters. #527 (ed06484) renamed Verify() to VerifyQueryString(), gave it external linkage so FT.AGGREGATE could call it, and updated the only call site.
• Feature/sortby implementation #618 (9b29188) re-added the original Verify() body verbatim, with no caller. Looks like a copy/paste slip.

No commit since has touched either validation body, so the dead copy is still byte-identical to VerifyQueryString(). It performs no check that VerifyQueryString() does not already perform.

No behavior change. Release build and all 23 unit test suites pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CmmwNpR7mMTD7CcTF9Xbd5

[github-actions]

Reviewers for this PR

• First Pass Reviewer: @Aksha1812 — Please do your best to do a detailed review on the PR and get a response on your feedback. Once the first pass is done, notify the maintainer assigned to this PR to follow up on the final review and getting the PR merged. You can reach out to the people owning the relevant code paths for more help on the review.
• Maintainer Reviewer: @yairgott — Once the first review is done, please follow up with a final review and help to merge the change in.

_{Assigned automatically to the least-assigned members of the reviewer pools in .github/reviewer-pools.json. Use /reviewer or /remove-reviewer to adjust.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8d04a3e7-731f-4a9e-80e2-26bb38e44104

📥 Commits

Reviewing files that changed from the base of the PR and between e4880d4 and 025a0ac.

📒 Files selected for processing (1)

• src/commands/ft_search_parser.cc

💤 Files with no reviewable changes (1)

• src/commands/ft_search_parser.cc

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The patch relocates query validation from the anonymous namespace to VerifyQueryString. SearchCommand::ParseCommand now calls the relocated function. Validation behavior remains unchanged.

Changes

Query verification

Layer / File(s)	Summary
Relocate query verification src/commands/ft_search_parser.cc	The Verify helper was replaced by VerifyQueryString. ParseCommand now calls VerifyQueryString(*this).

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 025a0

This change removes an unused duplicate query-validation function without altering the active validation path. No merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: removal of the unused duplicate Verify() function from ft_search_parser.
Description check	✅ Passed	The description directly explains the duplicate function, its history, the absence of behavior change, and validation results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}