Skip INCREX BYFLOAT overflow test under valgrind

[Baraa-Hasheesh]

Fixes #4723.

On x86 under valgrind the 1e4932 + 1e4932 operation returns a finite LDBL_MAX instead of +Inf,
this in turn breaks that test as it expects the isinf check to be exercised & for the operation to be rejected

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: cc8f8a05-1081-479e-b3f5-2f620e4e53cc

📥 Commits

Reviewing files that changed from the base of the PR and between 00a8a19 and e11e783.

📒 Files selected for processing (1)

• tests/integration/replication.tcl

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The replication overflow test now documents its incompatibility with x86 Valgrind and skips under Valgrind.

Changes

Overflow test handling

Layer / File(s)	Summary
Valgrind-specific test skip tests/integration/replication.tcl	The test documents that x86 Valgrind returns a finite result for 1e4932 + 1e4932 and skips the overflow test when Valgrind is enabled.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Suggested reviewers: enjoy-binbin

Merge Risk: ⚪ Minimal · up to e11e7

The change correctly skips the incompatible Valgrind test, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: skipping the INCREX BYFLOAT overflow test under Valgrind.
Description check	✅ Passed	The description explains the Valgrind-specific overflow behavior, the resulting test failure, and the issue being fixed.
Linked Issues check	✅ Passed	The change addresses #4723. In tests/integration/replication.tcl, the INCREX BYFLOAT arithmetic overflow does not propagate test now uses the valgrind:skip tag. The added comment records the fin…
Out of Scope Changes check	✅ Passed	The pull request changes only the affected test in tests/integration/replication.tcl. The comment and skip tag directly support the #4723 test-failure fix. No unrelated change is present in the revi…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.68%. Comparing base (00a8a19) to head (e11e783).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #4729      +/-   ##
============================================
- Coverage     80.83%   80.68%   -0.15%     
============================================
  Files           192      192              
  Lines        100853   100853              
============================================
- Hits          81523    81377     -146     
- Misses        19330    19476     +146     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.