Persist OPENSSL_PREFIX across builds

[sarthakaggarwal97]

Pointed out by @zuiderkwast in PR #3798.

Valkey remembers that TLS was enabled between builds, but not which OpenSSL installation was selected. After building with a custom OPENSSL_PREFIX, running a plain make later may discover a different system OpenSSL.

This changes the build flags, triggers an unexpected full rebuild, and links Valkey against an unintended OpenSSL installation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: f94bf83b-6f5a-44d8-a744-cfa8ed21382c

📥 Commits

Reviewing files that changed from the base of the PR and between 7b87fee and 5833a92.

📒 Files selected for processing (1)

• src/Makefile

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The persist-settings target now writes OPENSSL_PREFIX to .make-settings with the other build settings.

Changes

Build settings persistence

Layer / File(s)	Summary
Persist OpenSSL prefix src/Makefile	The persist-settings target records OPENSSL_PREFIX=$(OPENSSL_PREFIX) in .make-settings.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: yangbodong22011

Merge Risk: ⚪ Minimal · up to 5833a

The build setting is persisted and reused as intended, with no actionable merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: persisting OPENSSL_PREFIX across builds.
Description check	✅ Passed	The description explains the build behavior, the problem with losing OPENSSL_PREFIX, and the effect of the change. It directly relates to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[zuiderkwast]

Thank you!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.60%. Comparing base (7b87fee) to head (5833a92).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #4738      +/-   ##
============================================
- Coverage     80.67%   80.60%   -0.08%     
============================================
  Files           192      192              
  Lines        100856   100856              
============================================
- Hits          81369    81298      -71     
- Misses        19487    19558      +71     

see 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sarthakaggarwal97]

Daily Run - https://github.com/valkey-io/valkey/actions/runs/35395372072

I think the label even caused by no-release-notes label made the daily run hide and not show up in the PR CI

[sarthakaggarwal97]

The daily run looks okay! Merging it! thanks @zuiderkwast

[zuiderkwast]

@sarthakaggarwal97 Notice: This PR isn't in "To be backported" for 9.2 and valkyrie-ops didn't backport it to the 9.2 branch.

[sarthakaggarwal97]

Yeah, that's weird. Need to fix project rules for 9.2