Skip to content

Bugfix/snyk fix june 2026 - #33

Open
daniellmorrisGP wants to merge 10 commits into
valtech-sd:masterfrom
GiganticPlayground:bugfix/snyk-fix-june-2026
Open

Bugfix/snyk fix june 2026#33
daniellmorrisGP wants to merge 10 commits into
valtech-sd:masterfrom
GiganticPlayground:bugfix/snyk-fix-june-2026

Conversation

@daniellmorrisGP

Copy link
Copy Markdown

Fix snyk issues

daniellmorrisGP and others added 10 commits December 7, 2023 11:46
…pm-package

Make so we can directly use the npm package from this repo
When a request timed out the 408 was sent, but the outbound provider
promise kept running. If it later resolved or rejected, the .then()/.catch()
handlers tried to call res.send() on an already-sent response, throwing
ERR_HTTP_HEADERS_SENT with no handler — causing a fatal unhandledRejection.

Both handlers now check res.headersSent and bail out with an error log
instead of attempting to write to the closed response.

Also removes simple-mock as a dependency (was incorrectly in dependencies
rather than devDependencies) and replaces its single use with an inline spy.
- Use named request export from chai-http v5 (chai.request no longer attached via plugin)
- Replace chai.request(url) with chaiRequest.execute(url)
- Remove user-agent header from expected headers (superagent v10 no longer sends it)
semantic-release had no .releaserc or CI workflows configured.
ts-node was superseded by tsx, already configured in .mocharc.json.
Removes 443 packages and reduces audit vulnerabilities from 10 to 5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant