Add 'pause' and 'resume' options to the emulator#23
Merged
Conversation
This commit adds checks for the 'running' flag of the Application struct in order to ignore such messages when the application is not running.
This commit introduces a new menu bar category 'Emulation', which contains two buttons: 'Pause' and 'Resume'. This buttons can control emulation states.
This commit updates the Application struct by making the 'cpu' field Option<Cpu>. This allows to check if the CPU is initialized.
This commit makes the 'Pause' and 'Resume' buttons disableable when the conditions to be able to complete the action are not met.
This commit resumes program execution when there are no files to load.
This commit automatically cleans the framebuffer in case the file was reloaded.
This commit adds reinitialization of the CPU instance instead of creating a new one inside the Application instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done
This PR adds several new options for emulation control. Menu bar entries were added for such options, opened file manager was made to pause program execution.