fix(services): reorder binary path resolution, mux progress, thumbnails#44
fix(services): reorder binary path resolution, mux progress, thumbnails#44usrbinkat wants to merge 1 commit intovanloctech:mainfrom
Conversation
binary path resolution:
- reorder get_system_binary_candidates() in ffmpeg.rs, ytdlp.rs to check $PATH before /opt/homebrew/bin, /usr/local/bin, /usr/bin
- reorder get_deno_path()/check_deno_internal() in deno.rs: which/where before ~/.deno/bin
- fixes binary resolution for Nix, Homebrew, and other PATH-based environments
dev build sidecar:
- build.rs creates yt-dlp placeholder (<1024 bytes) for tauri_build::build() externalBin validation
- get_bundled_ytdlp_path() rejects placeholders under 1024 bytes
- get_ytdlp_path() falls through to system PATH as last resort in Auto mode
ffmpeg mux progress:
- add parse_ffmpeg_progress() to progress.rs matching time=HH:MM:SS, speed=Nx, Lsize=
- download.rs stderr task emits status=muxing when parse_ffmpeg_progress() matches
- add isMuxing to DownloadItem, set in DownloadContext.tsx/UniversalContext.tsx
- QueueItem.tsx/UniversalQueueItem.tsx render shimmer bar with Muxing label and speed
youtube thumbnail fallback:
- add getYouTubeVideoId() in UniversalQueueItem.tsx
- fallback to img.youtube.com/vi/{id}/mqdefault.jpg when item.thumbnail is null
- useEffect resets thumbError on item.thumbnail/item.url change
firefox profile sorting:
- add parse_firefox_profiles() to dependencies.rs
- parse Install section Default= to identify active profile path
- sort active profile first, replaces inline Name= scanning on macOS/Windows/Linux
|
Hi @usrbinkat, please re-check code with format. See more in CI failing. You need setup pre-commit hook for check format before push code |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ceb6eb43c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </div> | ||
| ) : item.isMuxing && item.progress === 0 ? ( | ||
| <div className="flex items-center gap-1.5"> | ||
| <span className="text-blue-300">Muxing</span> |
There was a problem hiding this comment.
The new Muxing status text is hardcoded in the queue UI instead of going through translation keys, which violates the i18n rule in /workspace/youwee/AGENTS.md (When adding new UI text, add keys to ALL 3 locales). As a result, Vietnamese/Chinese users will see mixed-language UI during muxing and this label cannot be translated without another code pass.
Useful? React with 👍 / 👎.
| if !sidecar_path.exists() { | ||
| if let Some(parent) = sidecar_path.parent() { | ||
| let _ = std::fs::create_dir_all(parent); | ||
| } | ||
| let _ = std::fs::write(&sidecar_path, b"#!/bin/sh\nexit 1\n"); |
There was a problem hiding this comment.
This writes a fake yt-dlp binary whenever the target sidecar is missing, regardless of build profile. In release packaging outside the CI path that pre-downloads yt-dlp, the build now succeeds with a stub instead of failing fast, and runtime commands later have no real bundled yt-dlp available. Please gate this placeholder logic to explicit dev/check contexts so release builds still fail when the real sidecar is absent.
Useful? React with 👍 / 👎.
2 participants
Problem
Binary path resolution in
ffmpeg.rs,ytdlp.rs, anddeno.rschecks hardcoded paths (/opt/homebrew/bin,/usr/local/bin,/usr/bin) before$PATHentries. This causes the app to miss binaries provided by Nix, Homebrew, or other package managers that express their binaries through PATH. On macOS, GUI apps launched from Finder don't inherit the user's shell PATH, making the hardcoded fallbacks essential — but they should be fallbacks, not the primary resolution mechanism.Expected: The app resolves yt-dlp, ffmpeg, and deno from the user's PATH first, then falls back to well-known locations.
Actual: Hardcoded paths win over PATH entries. A stale or missing binary at
/usr/local/bin/ffmpegshadows a working one in PATH (see #42).Additionally:
build.rsfor dev builds (a 22-byte shell stub) is returned as a valid bundled binary byget_bundled_ytdlp_path(), causing silent failures at runtime.deno.rschecks~/.deno/bin/deno(curl installer location) beforewhich deno, so a system-provided deno on PATH is shadowed by a stale home-dir install.--download-sectionsdownloads, yt-dlp delegates the mux/merge to ffmpeg. The progress parser only handles[download] X%lines — ffmpeg stderr progress (time=,speed=,Lsize=) is ignored, leaving the progress bar stuck at 0%.UniversalQueueItemhas no YouTube thumbnail fallback. When metadata fetch fails, the queue shows a blank grey placeholder instead of the readily availableimg.youtube.comthumbnail.--cookies-from-browser firefox:<profile>to target the wrong profile.Fix
Binary path resolution (ffmpeg.rs, ytdlp.rs, deno.rs)
get_system_binary_candidates()to iterate$PATHentries first, then append well-known fallback paths with deduplicationget_deno_path()andcheck_deno_internal():which/where(PATH) before~/.deno/bin/denofallbackDev build sidecar (build.rs, ytdlp.rs)
build.rscreates a minimal placeholder (#!/bin/sh\nexit 1\n) sotauri_build::build()passesexternalBinvalidation without a real per-platform binaryget_bundled_ytdlp_path()rejects files under 1024 bytes as placeholdersget_ytdlp_path()falls through to system PATH as last resort in Auto modeFFmpeg mux progress (progress.rs, download.rs, types.ts, contexts, queue components)
parse_ffmpeg_progress()matching ffmpeg stderr lines containingtime=HH:MM:SS,speed=Nx,Lsize=download.rsstderr task emitsdownload-progresswithstatus="muxing"whenparse_progress()returnsNoneandparse_ffmpeg_progress()matchesisMuxingfield toDownloadItem— set inDownloadContext.tsxandUniversalContext.tsxwithout overridingisLiveQueueItem.tsxandUniversalQueueItem.tsxrender an indeterminate shimmer bar with "Muxing" label, elapsed time, and speed whenisMuxing && progress === 0YouTube thumbnail fallback (UniversalQueueItem.tsx)
getYouTubeVideoId()at module level extracting video ID from YouTube URLsthumbnailUrlfalls back toimg.youtube.com/vi/{id}/mqdefault.jpgwhenitem.thumbnailis null or erroreduseEffectresetsthumbErroronitem.thumbnailoritem.urlchange to prevent stale error stateFirefox profile sorting (dependencies.rs)
parse_firefox_profiles()parsingprofiles.ini[Install*]sectionDefault=to identify the active profile pathName=line scanning on all three platforms (macOS, Windows, Linux)Fixes #42
Test plan
--download-sections— muxing shimmer bar displays with elapsed time and speed