Skip to content

+ RegisterControl for menu and lists, also removed redundant RegisterRaycastTarget calls #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r618 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

+ RegisterControl for menu and lists, also removed redundant RegisterRaycastTarget calls #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b2fa80
+ rm redundant RegisterRaycastTarget, add RegisterControl for menu + …
Jul 5, 2026
d061341
+ rm redundant RegisterRaycastTarget, add RegisterControl for menu + …
Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Runtime/Scripts/Controls/ImList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ public static void BeginList(this ImGui gui, ImSize size = default)

public static void BeginList(this ImGui gui, ImRect rect)
{
var id = gui.GetNextControlId();

gui.Box(rect, gui.Style.List.Box);
gui.RegisterRaycastTarget(rect);
gui.RegisterControl(id, rect);

var layoutRect = rect.WithPadding(gui.Style.List.Padding);
var maskRect = rect.WithPadding(gui.Style.List.Box.BorderThickness);
Expand Down
2 changes: 2 additions & 0 deletions Runtime/Scripts/Controls/ImMenuBar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public static void BeginMenuBar(ImGui gui, uint id, ImRect rect, int order)
gui.Layout.Push(ImAxis.Horizontal, rect);
gui.Canvas.PushOrder(order);

gui.RegisterControl(id, rect);

gui.Box(rect, in gui.Style.MenuBar.Box);
}

Expand Down
1 change: 0 additions & 1 deletion Runtime/Scripts/Controls/ImPopup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public static bool CloseButton(ImGui gui, int order)
{
gui.Canvas.PushNoClipRect();
gui.Canvas.PushOrder(order);
gui.RegisterRaycastTarget(gui.Canvas.ScreenRect);

var id = gui.GetNextControlId();

Expand Down