Add download links for Debian and RedHat packages#3
Open
cholmcc wants to merge 1 commit intovassalengine:mainfrom
Open
Add download links for Debian and RedHat packages#3cholmcc wants to merge 1 commit intovassalengine:mainfrom
cholmcc wants to merge 1 commit intovassalengine:mainfrom
Conversation
This will add download links for the Debian and RedHat packages. Since, on Linux, we cannot detect the distribution used by the client, we must give the all options for _any_ Linux client. Rather than having 3 different buttons, the `index.html` page will show a single button, and when the user hovers over that, the user will be presented with a drop-down menu to select between `Generic`, `Debian and derivatives`, and `RedHat and derivatives`. I think this is a better option than redirecting Linux users to the `download.html` page. The PR also adds Debian and RedHat package links to the `download.html` page, as well as a short instruction on how to install the _FlatPak_ package. Finally, the PR adds a link to the more verbose installation instructions on the Forum, as well as a link to the common problems post on the Forum.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add download links for the Debian and RedHat packages.
Since, on Linux, we cannot detect the distribution used by the client, we must give the all options for any Linux client. Rather than having 3 different buttons, the
index.htmlpage will show a single button, and when the user hovers over that, the user will be presented with a drop-down menu to select betweenGeneric,Debian and derivatives, andRedHat and derivatives.I think this is a better option than redirecting Linux users to the
download.htmlpage.The PR also adds Debian and RedHat package links to the
download.htmlpage, as well as a short instruction on how to install the FlatPak package.Finally, the PR adds a link to the more verbose installation instructions on the Forum, as well as a link to the common problems post on the Forum.