Fix a compilation error / warning due to missing check on return valu…#3
Open
alexmurray wants to merge 35 commits into
Open
Fix a compilation error / warning due to missing check on return valu…#3alexmurray wants to merge 35 commits into
alexmurray wants to merge 35 commits into
Conversation
The new strategy is set everything up in a header file, because it's easier than keeping the command line straight across several compilers. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
This mostly just means strace won't show lseek() every other line in most cases. Signed-off-by: Peter Jones <pjones@redhat.com>
Since strace defaults to 32-bytes per string, the debug log looks like: 3054 write(16, "linux-nvme.c:84 parse_nvme(): cu"..., 87) = 87 3054 write(16, "linux.c:556 device_get(): dev_pr"..., 79) = 79 3054 write(16, "linux.c:521 device_get(): trying"..., 36) = 36 3054 write(16, "linux-ata.c:54 parse_ata(): entr"..., 33) = 33 Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
This allows you to turn off declaration of efi_time_t and related functions in the case where it's declared someplace else, such as in some local code or another library's headers. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
log_() doesn't strictly need to be a macro, and making it one makes gcc analyzer output harder to read, so make it a real function. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Since 054193d, what was once efi_guid_redhat has been efi_guid_fwupdate. Since that's used at places that aren't exclusively Red Hat from, this is sub-optimal. Additionally, nothing currently uses (and it's possible nothing ever did) the invalid guid that is efi_redhat_2, though we can't remove the related symbols. This patch allocates a new guid value for efi_guid_redhat and makes efi_guid_redhat_2 an alias for it. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
vathpela
force-pushed
the
security-features
branch
17 times, most recently
from
November 18, 2021 17:35
f98bc57 to
0d9bc77
Compare
frozencemetery
force-pushed
the
security-features
branch
from
November 22, 2021 21:51
0d9bc77 to
b28771f
Compare
vathpela
force-pushed
the
security-features
branch
7 times, most recently
from
December 9, 2021 18:42
cdf93e9 to
67e26fd
Compare
vathpela
force-pushed
the
security-features
branch
3 times, most recently
from
January 7, 2022 21:56
6a4569a to
86f9a3d
Compare
frozencemetery
force-pushed
the
security-features
branch
2 times, most recently
from
January 10, 2022 18:36
620af55 to
bec837e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e from ftruncate()