disable two handlers, improve twitch, add mainclose setting#16
Open
6AA4FD wants to merge 5 commits intovayan:masterfrom
Open
disable two handlers, improve twitch, add mainclose setting#166AA4FD wants to merge 5 commits intovayan:masterfrom
6AA4FD wants to merge 5 commits intovayan:masterfrom
Conversation
added 3 commits
December 20, 2018 15:32
- disabled funnyordie because it's not working - took video namespace off funnyordie because it doesn't reflect site structure - added logic to determine if a twitch candidate is a stream or not
Added setting to choose whether it's okay to close the main tab if it gets opened in mpv
6AA4FD
changed the title
Author
|
i've also added a setting to toggle between leaving the tab to be opened present if it's focused, and closing the tab regardless |
vayan
reviewed
Dec 21, 2018
Owner
vayan
left a comment
vayan
left a comment
There was a problem hiding this comment.
Hello! Thanks for the pull request!!
I just had some small comments, and if you could keep the original indent it'll be nice too 😄
I'll take some time to test it out and merge it if it's good.
Thanks again 🙏
external-video.js
Outdated
| "*://*.streamable.com/*", | ||
| "*://*.liveleak.com/view*", | ||
| // "*://*.vid.me/*", // vidme is suspended | ||
| // "*://*.funnyordie.com/*", // youtube-dl returns unsupported for these |
Owner
There was a problem hiding this comment.
Right! you can remove them then no need to comment
external-video.js
Outdated
|
|
||
| function openInMpv(request) { | ||
| var lockedTabIndex = tabsLock.lastIndexOf(request.tabId); | ||
| console.log("mainClose:", settings.mainClose); |
settings/options.js
Outdated
| document.querySelector("#args").value = result.args || "--pause --ytdl-format='bestvideo[height<=?1080]+bestaudio/best'"; | ||
| } | ||
| function setMainClose(result) { | ||
| // console.log("mainclose is", result.mainClose); |
Author
|
alright, i've removed all the debug stuff, the lines for funnyordie and vidme, and changed the align level to 2 spaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've restructured the openInMpv function to make it more readable, and added detection for what kind of twitch page you're on so you can still use the browser.