Moregano Hitberon UI fix#769
Open
22Chaos wants to merge 2 commits intovck3000:masterfrom
Open
Conversation
… is in-game. who moregano saw as hitberon is NOT announced at the end of the game. who moregano saw as hitberon is NOT stored in the gameRecords database.
22Chaos
changed the title
vck3000
reviewed
Mar 20, 2026
Owner
There was a problem hiding this comment.
This doesn't seem right. Instead of making moregano see a hitberon, we should fix morgana so morgana doesn't see a hitberon tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Hitberon is in-game, Moregano should see a fellow dummy-spy as "Hitberon" to match the real Morgana's view.
Given how minor a bug fix this is, I'm not sure if it's worth storing in the gameRecords database/or even announcing at the end of the game. Let me know if it is required.