Skip to content

feat: replace details with popover for column visibility in ResultsToolbar #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzx1314 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: replace details with popover for column visibility in ResultsToolbar #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/features/queries/components/ResultsToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Button } from "@/components/ui/button";
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
import { useTranslation } from "react-i18next";

type ColumnVisibilityItem = {
Expand Down Expand Up @@ -125,13 +126,17 @@ export function ResultsToolbar({
</div>

<div className="flex shrink-0 items-center gap-2">
<details className="relative shrink-0">
<summary className="list-none">
<Button variant="outline" size="xs" asChild>
<span>{t("editor.columns")}</span>
<Popover>
<PopoverTrigger asChild>
<Button variant="outline" size="xs">
{t("editor.columns")}
</Button>
</summary>
<div className="absolute right-0 z-10 mt-1 min-w-44 border border-border bg-background p-2 shadow-sm">
</PopoverTrigger>
<PopoverContent
align="end"
sideOffset={4}
className="w-auto min-w-44 p-2"
>
<div className="mb-2 text-[10px] uppercase tracking-[0.18em] text-muted-foreground">
{t("editor.visibility")}
</div>
Expand All @@ -154,8 +159,8 @@ export function ResultsToolbar({
</label>
))}
</div>
</div>
</details>
</PopoverContent>
</Popover>

<Button
size="xs"
Expand Down