Fix notification stalls after timeouts - #147
Merged
Merged
Conversation
In cases where ARRAY_DELETE template is used inside another loop iterators may clash causing internal iterator being initialized by random value rather than intended initialization value.
Mark code after failed as unreachable. Improves reasoning of newer versions of clang-tidy which tends to complain about errors in code after assert.
If there are no waiters for given notification then don't try to search timers.
If no existing timer entry was found while timer is configured then don't examine offset given. This was achieved by swapping operands inside if statement, so that if offset given is out of range it won't be used to access array content.
After kernel was shutdown, code flow doesn't continue here. Mutes some static analyzer errors.
If notification times out then remove the waiting thread from notification waitlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If wait for object timed out, then the thread wasn't removed from list of waiting threads. This caused subsequent notifications to stall as notify_object assumed that someone is already waiting for notification so it did not queue it.
This exposed another bug in algorithm library where array-delete iterator name was too generic and could cause to shadow exactly the variable which was used to initialize it.
Two more complains by static analyzer were fixed which prevent out of bounds access in code. One of them has potential to speed notification processing a bit in case that there is no thread waiting for notification.