Fixes and improvements in STM32 platform and FindCMSIS - #160
Merged
Conversation
FindCMSIS generated RTE_Headers.h which contained wrong header filename. It used DEVICE variable content instead of actual device header filename. More diagnostics for errors that are diagnosable during config time.
Improve compatibility with both older and newer versions of CubeMX CMake generator. Newer CubeMX generates CMakeLists.txt that requires cmake/stm32cubemx be included after executable has been created. This version of platform support supports that by deferring of stm32cubemx_headers generation to the end of configuration step. Detection of linker script with name both in uppercase and lowercase is supported as different CubeMX generators and different packages use different case. Define with device name is made automatically, so CubeMX headers don't complain about specific device not being selected.
New FindCMSIS requires the existence of system header file, so create empty files to make it believe it found legit CMSIS pack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve compatibility of both FindCMSIS and STM32 platform script.
RTE_Components.h header is generated using correct device header name, binary output directory is added to include paths so #include <RTE_Components.h> works as expected.
STM32 platform script improves compatibility with newer CubeMX generator's CMakeLists.txt format.