feat: add simulated CCA attester - #4
Merged
Merged
Conversation
thomas-fossati
approved these changes
Jul 17, 2026
thomas-fossati
left a comment
thomas-fossati
left a comment
Contributor
There was a problem hiding this comment.
Excellent contribution, thanks!
I have left a few comments inline for your consideration -- none of which are blocking.
Contributor
|
Thanks for addressing all my comments. This looks ready to ship. |
| realm_claims.challenge = nonce.to_vec(); | ||
| realm_claims.public_key = rak_cose_key_bytes; | ||
|
|
||
| // Convert to CBOR via From impls. |
There was a problem hiding this comment.
Can you please make line 50 comment more clear ??
Contributor
There was a problem hiding this comment.
Updated the comment to explain which From impls are involved, where they're defined (types.rs), and what they do (map claim fields to spec-defined CBOR integer keys and value types).
yogeshbdeshpande
approved these changes
Jul 28, 2026
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the great work!!
- Replace the old FakeTsmBuilder with SimulatedTokenBuilder that constructs real CBOR tag 399 tokens from JSON claims and JWK keys - Add encode_cca_token() for building CCA tokens with two COSE_Sign1 signatures (platform + realm) using ES384 on P-384 - Add CcaSimulatedAttester implementing the Attester trait - Add CcaRatsdAttester that posts to RATSD and parses the CMW envelope - Add crypto helpers: load_p384_jwk, build_rak_cose_key, sign_cose_sign1, is_supported_hash_alg, compute_hash - Add serde-enabled CCA token types with CBOR conversions - Add decode_cca_token() and pretty_print_token() utilities - Add CBOR key constants per the Arm CCA attestation token spec - Switch cmw dependency from git to crates.io v0.1.1 Signed-off-by: BISWAS, SREYAN <SREYAN.BISWAS@fujitsu.com> fix: clarify comment on line 50 in encode.rs Explain which From impls are used for the CBOR conversion, where they are defined, and what they do -- addressing review comment from PR veraison#4. Signed-off-by: BISWAS, SREYAN <SREYAN.BISWAS@fujitsu.com>
Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Collaborator
Author
|
@thomas-fossati we have addressed all review comments. If everything looks good, please merge this PR. |
thomas-fossati
pushed a commit
that referenced
this pull request
Jul 31, 2026
- Replace the old FakeTsmBuilder with SimulatedTokenBuilder that constructs real CBOR tag 399 tokens from JSON claims and JWK keys - Add encode_cca_token() for building CCA tokens with two COSE_Sign1 signatures (platform + realm) using ES384 on P-384 - Add CcaSimulatedAttester implementing the Attester trait - Add CcaRatsdAttester that posts to RATSD and parses the CMW envelope - Add crypto helpers: load_p384_jwk, build_rak_cose_key, sign_cose_sign1, is_supported_hash_alg, compute_hash - Add serde-enabled CCA token types with CBOR conversions - Add decode_cca_token() and pretty_print_token() utilities - Add CBOR key constants per the Arm CCA attestation token spec - Switch cmw dependency from git to crates.io v0.1.1 Signed-off-by: BISWAS, SREYAN <SREYAN.BISWAS@fujitsu.com> fix: clarify comment on line 50 in encode.rs Explain which From impls are used for the CBOR conversion, where they are defined, and what they do -- addressing review comment from PR #4. Signed-off-by: BISWAS, SREYAN <SREYAN.BISWAS@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old static-blob FakeTsmBuilder with a real SimulatedTokenBuilder that builds spec-compliant CCA tokens (CBOR tag 399) from JSON claims and JWK keys signed with ES384. No hardware or RATSD daemon needed.