ci: drop the stale LICENSE.md requirement from make check - #2
Merged
Merged
Conversation
`make check` required both LICENSE and LICENSE.md. Only LICENSE exists, so the check has been failing on main for every push and pull request. Repository evidence establishes LICENSE as the canonical licence artifact: - LICENSE contains the full Creative Commons Attribution 4.0 International text (395 lines); - README's Licensing section names CC BY 4.0 and refers certification marks to TRADEMARKS.md, implying no second licence file; - `git log --all -- LICENSE.md` is empty: the file has never existed on any branch; - the Makefile's required list is the only reference to LICENSE.md anywhere in the repository; - there is no packaging or build metadata that would require a second file. So the requirement is stale, not the tree. Removing the entry is the minimum repair. A second licence file is deliberately not created: duplicating licence text to satisfy a stale check would create two artifacts that can drift apart on a question where drift matters. No specification, schema, licence terms, governance or versioning content is changed. Verification: - base reproduces the failure: `Missing required file: LICENSE.md`, exit 2 - this branch: `make check` OK exit 0, `make schema` OK exit 0, `make ci` exit 0 Signed-off-by: Arkadiy Miteiko <am@veraxis.io> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pkw68qW3iRaeJsiMPBEPvW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make check— the only gate.github/workflows/ci.ymlruns — fails onmainfor every push and every pull request:The required-file list names both
LICENSEandLICENSE.md. The repository contains onlyLICENSE.Which file is canonical
Inspected
LICENSE, theMakefile, repository documentation and packaging metadata before changing anything. The evidence is one-sided:LICENSEREADME.md→ LicensingTRADEMARKS.md; implies no second licence filegit log --all -- LICENSE.mdLICENSE.mdhas never existed on any branchLICENSE.mdreq=(…)arraypyproject.toml,setup.py,package.json)LICENSEis the canonical artifact. The requirement is stale; the tree is correct.Repair
Remove
LICENSE.mdfrom the required-file list. One line, one file.A second licence file was deliberately not created. Satisfying the check by duplicating licence text would leave two artifacts that can drift apart, on precisely the question where drift is least acceptable. The work order authorizing this repair says the same: do not create a second licence file merely to satisfy a stale check unless repository evidence explicitly requires two distinct files. It does not.
Verification
b7bae309cd39b6be2f1669aff75c4feb9cf18668reproduces the failureMissing required file: LICENSE.md, exit 2make checkOK: required files present, exit 0make schemaOK: schema JSON parses, exit 0make cib7bae309cd39b6be2f1669aff75c4feb9cf18668d9ebd2b5646dcd4028a28dcf1e05e31d9be7fd2bScope
Diff is limited to the minimum CI/build-hygiene repair:
Makefile, 1 insertion, 1 deletion. No specification, schema, licence terms, governance or versioning content is touched.Relationship to CAT-ALIGN-001
Separate and deliberately not folded into the documentation work. #1 is the CAT-ALIGN-001 category-alignment PR; it inherits this same pre-existing failure and carries a comment saying so. This PR fixes the cause. Merging this one first should turn #1 green with no change to #1 itself.
Generated by Claude Code