Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The big differences/advantages compared to asyncio.wait: * New futures to wait on may be added while the object is already being waited on * Completion order of the tasks is not lost. However, completion *batching* is, which is actually a plus for us. I think that MultiWaiter should be deterministic enough to use with workflows/temporal.
This is a big improvement!
I'm not sure if this one is an improvement though
anbuzin
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big differences/advantages compared to asyncio.wait:
is already being waited on
batching is, which is actually a plus for us.
I think that MultiWaiter should be deterministic enough to use
with workflows/temporal.
Update ToolRunner and merge to use this, though I'm not sure the merge
one is an improvement.