Skip to content

Fix the exclude_if on model_input even if the model is deep copied#178

Merged
msullivan merged 1 commit into
mainfrom
tool-result-trouble
Jun 17, 2026
Merged

Fix the exclude_if on model_input even if the model is deep copied#178
msullivan merged 1 commit into
mainfrom
tool-result-trouble

Conversation

@msullivan

Copy link
Copy Markdown
Contributor

No description provided.

@msullivan msullivan requested a review from anbuzin June 17, 2026 22:50
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-python Ready Ready Preview, Comment Jun 17, 2026 10:52pm

@vercel vercel Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

get_model_input and has_model_input use identity checks (is/is not _MODEL_INPUT_UNSET) that break after model_copy(deep=True), since the deep copy creates a fresh _ModelInputUnset instance that is not the original singleton.

Fix on Vercel

@msullivan msullivan merged commit 3620dc2 into main Jun 17, 2026
7 checks passed
@msullivan msullivan deleted the tool-result-trouble branch June 17, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant