Implement merge for async iterables#54
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anbuzin
approved these changes
Apr 28, 2026
1st1
reviewed
Apr 28, 2026
|
|
||
| # Launch a task doing anext on every iterator | ||
| tasks: list[asyncio.Future[T] | None] = [ | ||
| asyncio.ensure_future(iter.__anext__()) for iter in aiters |
Collaborator
There was a problem hiding this comment.
Use the anext() / aiter() built-ins
1st1
reviewed
Apr 28, 2026
| iter = aiters[idx] | ||
| tasks[idx] = asyncio.ensure_future(iter.__anext__()) | ||
| yield t.result() | ||
| except Exception: |
Collaborator
There was a problem hiding this comment.
Use async with TaskGroup() instead of this
(Was called interleave in discussions earlier, but @elprans thought interleave sounded too deterministic.)
1st1
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Was called interleave in discussions earlier, but @elprans thought
interleave sounded too deterministic.)