fix(s3): fix binary data corruption on upload/download#53
Open
zaru wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(s3): fix binary data corruption on upload/download#53zaru wants to merge 1 commit intovercel-labs:mainfrom
zaru wants to merge 1 commit intovercel-labs:mainfrom
Conversation
- PutObject used `c.req.text()` which corrupted binary files (docx, xlsx, etc.) via lossy UTF-8 conversion - Switch to `arrayBuffer()` and store body as base64, decode back to Buffer on GET using `c.body()` - Fix ETag and content_length to reflect actual binary byte counts ## Changes - `c.req.text()` → `c.req.arrayBuffer()` + base64 encoding for storage - `c.text()` → `c.body()` + base64 decoding for retrieval - Widen `md5()` type signature to accept `string | Buffer` - Add binary data round-trip test
Contributor
|
@zaru is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c.req.text()which corrupted binary files (docx, xlsx, etc.) via lossy UTF-8 conversionarrayBuffer()and store body as base64, decode back to Buffer on GET usingc.body()Reproduce
Changes
c.req.text()→c.req.arrayBuffer()+ base64 encoding for storagec.text()→c.body()+ base64 decoding for retrievalmd5()type signature to acceptstring | BufferI've confirmed that base64 encoding resolves the binary corruption issue, but I'm not sure if this is the best approach for the project. If there's a more suitable way to handle binary data storage, I'd appreciate any feedback or suggestions. Happy to revise the implementation accordingly.