Wire approval-review-benchmark tests into the test step - #550
Open
espetro wants to merge 1 commit into
Open
Conversation
The test-approval-review-benchmark step existed but was never depended on by the aggregate test step, so zig build test never ran the approval review benchmark qualification tests. The sibling ui-activity benchmark tests were already wired in; this adds the missing dependency so both benchmark test units run as part of the standard gate.
espetro
marked this pull request as ready for review
September 1, 2026 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of the cleanup surfaced in #549.
Problem
The
test-approval-review-benchmarkstep is declared inbuild.zigbut nothing depends on its run artifact within the aggregateteststep, sozig build testnever runs the file-diff approval review qualification tests. The siblingtest-ui-activity-benchmarkunit is already wired in (build.zig:219); this one was missed.Change
One line:
test_step.dependOn(&run_approval_review_bench_tests.step)next to the existing step declaration. The standalonetest-approval-review-benchmarkstep is unchanged.Validation
zig fmt --checkcleanzig build test-approval-review-benchmark- 2/2 tests passzig build test- runs the aggregate gate; the step now appears in the run and the 2 approval-review tests execute (total count goes from 8,633 to 8,636 locally)./zig-out/bin/fx --versionand--helpsmoke-checked from a fresh build