Skip to content

fix(github): compose channel event handlers - #642

Open
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/channel-event-composition-623
Open

fix(github): compose channel event handlers#642
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/channel-event-composition-623

Conversation

@iroiro147

Copy link
Copy Markdown
Contributor

Summary

  • add composable channel event helpers (afterDefault, beforeDefault, replaceDefault) to the public eve/channels surface
  • make GitHub channel events compose after built-in handlers by default, so custom status handlers do not disable checkout, replies, or failure comments unless replacement is explicit
  • document the GitHub event composition contract and add regression coverage for default reply, checkout preservation, and explicit replacement

Refs #623.

Tests

  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/public/channels/github/githubChannel.test.ts
  • pnpm --filter eve run typecheck
  • pnpm exec oxfmt --check packages/eve/src/public/definitions/channel.ts packages/eve/src/public/channels/index.ts packages/eve/src/public/channels/github/githubChannel.ts packages/eve/src/public/channels/github/defaults.ts packages/eve/src/public/channels/github/githubChannel.test.ts docs/channels/github.mdx .changeset/channel-event-composition.md
  • pnpm exec oxlint --deny-warnings packages/eve/src/public/definitions/channel.ts packages/eve/src/public/channels/index.ts packages/eve/src/public/channels/github/githubChannel.ts packages/eve/src/public/channels/github/defaults.ts packages/eve/src/public/channels/github/githubChannel.test.ts
  • pnpm docs:check
  • pnpm guard:invariants
  • git diff --check
  • pnpm changeset status --since origin/main

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@iroiro147
iroiro147 force-pushed the fix/channel-event-composition-623 branch from e683d8a to 7ed7a87 Compare July 12, 2026 13:09
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased this onto current main and pushed signed head 7ed7a87c. I also completed the public composition contract: minor semver, direct coverage for bare/after/before/replace ordering, missing defaults, awaited sequencing, and exception short-circuiting; user-facing docs; JSDoc on the exported API; and public portability coverage for GitHubChannelEventHandlers. Verified under Node 24 with 47 focused unit tests, the 8-case public portability scenario, package typecheck, all documentation checks, invariant checks, and git diff --check. Fresh CI is running.

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@iroiro147
iroiro147 force-pushed the fix/channel-event-composition-623 branch from 7ed7a87 to 73060dd Compare August 1, 2026 04:15
@iroiro147

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (was CONFLICTING). Resolved the import conflict in packages/eve/src/public/channels/github/githubChannel.ts (HEAD's readNonEmptyString import + this branch's composeChannelEvents/ChannelEventConfigMap import — both retained). Verification on the rebased head: typecheck ✓ and the github-channel + channel-definition unit tests pass (48/48).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant