Skip to content

fix: serve directory index when path segment contains a dot (e.g. /docs/1.4) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ethan-Arrowood wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: serve directory index when path segment contains a dot (e.g. /docs/1.4) #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7c5d57
fix: serve directory index when path segment contains a dot
Ethan-Arrowood Mar 31, 2026
fcbc82d
test: expand dotted-path fixture coverage
Ethan-Arrowood Mar 31, 2026
aa7030d
fix: update 1.4 references (fixture content and inline comment)
Ethan-Arrowood Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,12 @@ module.exports = async (request, response, config = {}, methods = {}) => {
if (path.extname(relativePath) !== '') {
try {
stats = await handlers.lstat(absolutePath);
// If the path looks like it has an extension but actually resolves to a
// directory (e.g. /docs/1.4 where path.extname returns '.4'), clear stats
// so findRelated can fall back to index.html or the .html sibling.
if (stats && stats.isDirectory()) {
stats = null;
}
} catch (err) {
if (err.code !== 'ENOENT' && err.code !== 'ENOTDIR') {
return internalError(absolutePath, response, acceptsJSON, current, handlers, config, err);
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/1.2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<html><body>Version 1.2</body></html>
1 change: 1 addition & 0 deletions test/fixtures/1.3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<html><body>Version 1.3 html file</body></html>
1 change: 1 addition & 0 deletions test/fixtures/1.3/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<html><body>Version 1.3 directory index</body></html>
1 change: 1 addition & 0 deletions test/fixtures/1.4/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<html><body>Version 1.4</body></html>
67 changes: 67 additions & 0 deletions test/integration.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,3 +1375,70 @@ test('etag header is set', async () => {
'"ba114dbc69e41e180362234807f093c3c4628f90"'
);
});

test('serve index.html for directory whose name contains a dot (e.g. /1.4)', async () => {
const target = '1.4';
const index = path.join(fixturesFull, target, 'index.html');

const url = await getUrl({
cleanUrls: true,
directoryListing: false,
trailingSlash: false
});

const response = await fetch(`${url}/${target}`);
const content = await fs.readFile(index, 'utf8');
const text = await response.text();

expect(response.status).toBe(200);
expect(text).toBe(content);
});

test('redirect /1.4/ to /1.4 when trailingSlash is false', async () => {
const target = '1.4';

const url = await getUrl({
cleanUrls: true,
directoryListing: false,
trailingSlash: false
});

const response = await fetch(`${url}/${target}/`, {
redirect: 'manual',
follow: 0
});

const location = response.headers.get('location');
expect(response.status).toBe(301);
expect(location).toBe(`${url}/${target}`);
});

test('serve 1.2.html via cleanUrls when requested as /1.2', async () => {
const url = await getUrl({
cleanUrls: true,
directoryListing: false,
trailingSlash: false
});

const content = await fs.readFile(path.join(fixturesFull, '1.2.html'), 'utf8');
const response = await fetch(`${url}/1.2`);
const text = await response.text();

expect(response.status).toBe(200);
expect(text).toBe(content);
});

test('prefer directory index.html over .html sibling when both 1.3/ and 1.3.html exist', async () => {
const url = await getUrl({
cleanUrls: true,
directoryListing: false,
trailingSlash: false
});

const content = await fs.readFile(path.join(fixturesFull, '1.3', 'index.html'), 'utf8');
const response = await fetch(`${url}/1.3`);
const text = await response.text();

expect(response.status).toBe(200);
expect(text).toBe(content);
});