Skip to content

fix(a11y): add keyboard focus trap for Help sidebar and lightbox#4226

Open
Innagl wants to merge 1 commit into
developfrom
feature/overlay-a11y-custom-overlays
Open

fix(a11y): add keyboard focus trap for Help sidebar and lightbox#4226
Innagl wants to merge 1 commit into
developfrom
feature/overlay-a11y-custom-overlays

Conversation

@Innagl

@Innagl Innagl commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Introduce overlay accessibility utilities for the Help sidebar, TabBar, and user guide image lightbox, yielding Tab/Esc to nested MUI modals.

Write your issue number after "Fixes "

Fixes #4225

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I have avoided using hardcoded values to ensure scalability and maintain consistency across the application.
  • I have ensured that font sizes, color choices, and other UI elements are referenced from the theme.
  • My pull request is focused and addresses a single, specific feature.
  • If there are UI changes, I have attached a screenshot or video to this PR.
  • If I added or modified an API endpoint, the change is reflected in the generated OpenAPI spec (npm run generate:swagger).
  • If the endpoint requires authentication, it uses authenticateJWT and the generated spec declares bearerAuth security.
  • I ran npm run check:api-drift and committed the regenerated swagger.yaml and endpoints.ts.
  • If this PR adds or modifies an organization-scoped table, the tenant isolation registry and test matrix are updated. See the tenant isolation runbook for details.
Screenshot 2026-07-02 at 6 22 52 PM Screenshot 2026-07-02 at 6 51 05 PM

Introduce overlay accessibility utilities for the Help sidebar, TabBar,
and user guide image lightbox, yielding Tab/Esc to nested MUI modals.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Innagl Innagl added this to the 2.5 milestone Jul 2, 2026
@Innagl Innagl self-assigned this Jul 2, 2026
@Innagl Innagl added enhancement New feature or request frontend Frontend related tasks/issues labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Frontend related tasks/issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add keyboard focus trap for Help sidebar, TabBar, and image lightbox

1 participant