Fix: WooCommerce order status not updated for BI-SNAP & DANA#85
Open
robby-xp wants to merge 1 commit into
Open
Fix: WooCommerce order status not updated for BI-SNAP & DANA#85robby-xp wants to merge 1 commit into
robby-xp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Payments that settle successfully in Midtrans don't update the WooCommerce order status for DANA and VA transfers to Danamon, BSI, Seabank, and Saqu. Other payment methods are unaffected.
Cause
In
handleMidtransNotificationRequest(), aftergetStatusFromMidtransNotif()returns the verified status, the order is resolved from$midtrans_notification->order_id.For BI-SNAP & DANA payment methods, the get-status response returns the
transaction_idin theorder_idfield, sowc_get_order()fails anddo_action( "midtrans-handle-valid-notification", ... )never fires — leaving the WooCommerce order status unchanged.Fix
In
class/class.midtrans-gateway-notif-handler.php, right after the status call, restore the correctorder_idfrom the notification body that still holds the correct WooCommerceorder_id: