TransportTuple: replace uint64_t hash with new PortManager::PortRangeKeyHash#1823
Open
penguinol wants to merge 16 commits into
Open
TransportTuple: replace uint64_t hash with new PortManager::PortRangeKeyHash#1823penguinol wants to merge 16 commits into
PortManager::PortRangeKeyHash#1823penguinol wants to merge 16 commits into
Conversation
Implement `TransportTuple::TupleKey` and `TransportTuple::TupleKeyHash` Rewrite `TransportTuple::Compare`
ibc
reviewed
Jun 6, 2026
Member
|
Please run "npm run lint" and "npm run format:node" to fix. And "npm run release:check" to validate everything. |
Contributor
Author
|
|
Member
|
It's failing in CI: https://github.com/versatica/mediasoup/actions/runs/27118410859/job/80029913564#step:10:1 Can you please merge v3 branch? |
PortManager::PortRangeKeyHash
ibc
reviewed
Jun 9, 2026
ibc
reviewed
Jun 9, 2026
ibc
reviewed
Jun 9, 2026
ibc
reviewed
Jun 9, 2026
ibc
reviewed
Jun 10, 2026
ibc
left a comment
Member
There was a problem hiding this comment.
Thanks. I am on vacation so probably won't be able to review until next Monday but everything looks good so far.
jmillan
approved these changes
Jun 10, 2026
Co-authored-by: José Luis Millán <jmillan@aliax.net>
Co-authored-by: José Luis Millán <jmillan@aliax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
TransportTuple::TupleKeyandTransportTuple::TupleKeyHashRewriteTransportTuple::Compare