Conversation
- Added `setTotalSteps`, `incrementStep`, `setStep` methods. - Added `totalSteps` and `currentStep` properties. - Added tests for step-based progress tracking.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 770b9141da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($steps <= 0) { | ||
| throw new \InvalidArgumentException('Total steps must be greater than 0'); | ||
| } | ||
| $this->totalSteps = $steps; |
There was a problem hiding this comment.
Calling setTotalSteps() updates only totalSteps and leaves currentStep untouched, so reusing the same instance for a new task carries over the old step counter. In that scenario, the next incrementStep() computes progress from stale state (often jumping straight to 100%), which makes the new run report incorrect progress data.
Useful? React with 👍 / 👎.
| if ($this->totalSteps === null) { | ||
| throw new \LogicException('Total steps not set. Call setTotalSteps() first.'); | ||
| } | ||
| $this->currentStep = $step; |
There was a problem hiding this comment.
setStep() accepts negative integers and stores them directly in currentStep, which can produce an invalid negative step count while local progress is clamped to 0. This creates inconsistent state (getCurrentStep() negative, getLocalProgress() non-negative) and can skew subsequent step calculations if a caller passes a computed value below zero.
Useful? React with 👍 / 👎.
1 participant
This change introduces step-based progress tracking to the
Progressabletrait. It allows users to define the total number of steps and increment the current step, automatically calculating the progress percentage. This is useful for tasks where the number of items is known.PR created automatically by Jules for task 8495322058049971929 started by @insign