Skip to content

Make target completion inserts a duplicated quoted command #167

Description

@bingoYB

Bug description

Make targets are suggested with a duplicated make prefix inside quotes. Accepting a suggestion inserts that incorrect command into the prompt.

Steps to reproduce

  1. In a directory containing this Makefile:

    gen-all:
    	@echo done
  2. Type make in a shell running IRIS.

  3. Select the gen-all target from the completion menu.

Actual behavior

The menu displays make "make gen-all", and accepting it inserts make "make gen-all" into the prompt. That passes make gen-all as one quoted argument instead of invoking the gen-all target.

Expected behavior

The suggestion should display and insert make gen-all.

Additional context

In commands/runner/makefile.go, the generator includes prefix in each suggestion's Cmd. The completion lookup also adds the command prefix and quotes suggestions containing spaces, which appears to cause the duplicated, quoted command.

Screenshot

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions