Open
Conversation
Clang flow analysis flags resp_data in process_response as possibly uninitialized when find_request returns NULL. kmod/src/net.c:533:6: error: variable 'resp_data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] In practice the read is harmless because resp_func stays NULL in that path and call_resp_func only dereferences resp_data when resp_func is non-NULL. Initialize at declaration. Signed-off-by: Auke Kok <auke.kok@versity.com>
Clang's scan-build found this leak when we get an invalidation for a lock we no longer have. Free ireq to fix. Signed-off-by: Auke Kok <auke.kok@versity.com>
A malformed message encountered here increases the counter, but doesn't tear down the connection because of the nested for loops. The comments indicate that that is the expected behavior - a misbehaving client should not be tolerated. Signed-off-by: Auke Kok <auke.kok@versity.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 leak, a swallowed network error, and a warning squelch.