Merged
Conversation
lrm25
force-pushed
the
test/rest_list_objects_v2_queries
branch
5 times, most recently
from
04d63da to
41f4721
Compare
anodelman
requested changes
Apr 10, 2026
lrm25
force-pushed
the
test/rest_list_objects_v2_queries
branch
2 times, most recently
from
0d25058 to
35e2399
Compare
anodelman
requested changes
Apr 13, 2026
| bucket_list=$(xmllint --xpath '//*[local-name()="Bucket"]/*[local-name()="Name"]/text()' "$1") | ||
| local response | ||
| if ! response=$(xmllint --xpath '//*[local-name()="Bucket"]/*[local-name()="Name"]/text()' "$1" 2>&1); then | ||
| if [[ "$response" == *"XPath set is empty" ]]; then |
There was a problem hiding this comment.
xmllint often appends a newline or specific formatting to its error messages. Using a wildcard at the beginning of the check—or checking the exit status directly—makes it more bulletproof
if [[ "$response" == *"XPath set is empty"* ]]; then
|
|
||
| local response error | ||
| if ! response=$(check_count_and_keys "$1" "$3" "${@:5}" 2>&1); then | ||
| log 2 "error checking count and keys: $xml_file" |
There was a problem hiding this comment.
xml_file hasn't been defined here, it happens after this if block.
|
|
||
| xml_data="$response" | ||
| if ! check_if_element_exists "$xml_data" "$2" "ListBucketResult" "StartAfter"; then | ||
| log 2 "error checking if element '$key' exists" |
There was a problem hiding this comment.
key isn't defined here, probably mean $2?
| } | ||
|
|
||
| list_objects_delimiter() { | ||
| run assert_param_count "ListObjects version" 1 $# |
There was a problem hiding this comment.
this is all using run/assert - but that should be done at the test level, not in the helpers.
Contributor
Author
There was a problem hiding this comment.
It's a common call for two tests with just a version change, can move it though
| fi | ||
| status_line_idx=1 | ||
| status_code="" | ||
| continue_count=0 |
| return 1 | ||
| fi | ||
| if check_if_element_exists "$1" "$2" "${@:3}"; then | ||
| log 2 "element '$2' should not exist in data (data: $(cat "$1"))" |
There was a problem hiding this comment.
Just a risk here is the file is really big this log line could be really bloated.
lrm25
force-pushed
the
test/rest_list_objects_v2_queries
branch
from
9d1f4c7 to
a53e9a1
Compare
anodelman
approved these changes
Apr 14, 2026
lrm25
force-pushed
the
test/rest_list_objects_v2_queries
branch
from
a53e9a1 to
1632c8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.