test: add github actions functional tests for posix sidecar option#2050
Open
benmcclelland wants to merge 2 commits intomainfrom
Open
test: add github actions functional tests for posix sidecar option#2050benmcclelland wants to merge 2 commits intomainfrom
benmcclelland wants to merge 2 commits intomainfrom
Conversation
Enough people are making use of sidecar that we need to add a CI test to make sure we have some coverage with this mode.
Unlike xattr metadata which is tied to the filesystem object and removed automatically, sidecar metadata lives in a parallel directory tree and must be deleted explicitly. Add DeleteAttributes calls after removing bucket directories, null-version files, and versioned object files. Also add an os.Stat existence check in GetObjectTagging and PutObjectTagging when no versionId is given, since sidecar's StoreAttribute/RetrieveAttribute do not naturally return ErrNotExist for missing objects the way xattr operations do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enough people are making use of sidecar that we need to add a CI test to make sure we have some coverage with this mode.