feat: implement presigned URL generation in webui#2059
Open
apognu wants to merge 1 commit intoversity:mainfrom
Open
feat: implement presigned URL generation in webui#2059apognu wants to merge 1 commit intoversity:mainfrom
apognu wants to merge 1 commit intoversity:mainfrom
Conversation
Collaborator
|
This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it. |
apognu
force-pushed
the
feat/webui-generate-presigned-url
branch
3 times, most recently
from
37c5014 to
5a10255
Compare
apognu
force-pushed
the
feat/webui-generate-presigned-url
branch
from
5a10255 to
baa8d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements presigned URL generation for objects, with a configurable expiration (in minutes, hours or days). It reuses the pre-existing
presignUrl()function fromapi.jsand only implements a UI for it.Note: I didn't know where you get your icons from, so the style is jarringly different for the two icons I added (the pen and the clipboard). I will change them if you tell me what collection to use.