Fix MQTT 5 QoS 2 pub reply encoding (5.1 branch) - #302
Closed
shblue21 wants to merge 1 commit into
Closed
Conversation
Motivation: MQTT 5 PUBREC, PUBREL, and PUBCOMP APIs accept reason codes and properties, but MqttEndpointImpl used a variable header type that Netty does not encode them from. As a result, supplied reason codes and properties were not written on the wire. Changes: Use MqttPubReplyMessageVariableHeader for PUBREC, PUBREL, and PUBCOMP replies. Add wire-level MQTT 5 regression tests covering PUBREC, PUBREL, and PUBCOMP reason codes and properties. Signed-off-by: Jihun Kim <shblue21@naver.com> (cherry picked from commit d2a720e)
Member
|
Usual failure, we need this cherry-pick being merged #304 before you can rebase and tests pass. |
Contributor
Author
|
Got it, thanks! |
Contributor
Author
|
Already cherry-picked into 5.1, closing this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Backport of #296 for the 5.1 branch.
This applies the same MQTT 5 QoS 2 PUBREC, PUBREL, and PUBCOMP reply encoding fix from master.
A wire-level regression test covers PUBREC, PUBREL, and PUBCOMP reason codes and properties.
Conformance:
I have signed the ECA