Skip to content

Cherry-pick PR #301 on the 5.1 branch #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppatierno wants to merge 1 commit into
base: 5.1
Choose a base branch
from
+5 −3
Open

Cherry-pick PR #301 on the 5.1 branch #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/test/java/io/vertx/mqtt/test/server/MqttServerNetworkIssueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,12 @@ public void deliveryComplete(IMqttDeliveryToken iMqttDeliveryToken) {

async.await();

// the connection should be dropped within a 1 second window after the expected keep alive timeout
long elapsed = ended - started;
// consider a range of 500 ms
context.assertTrue(elapsed > (timeout * 1000 - 500) && elapsed < (timeout * 1000 + 500),
elapsed + " > " + ((timeout * 1000 - 500)) + " && " + elapsed + " < " + (timeout * 1000 + 500) + " != true");
long expectedMin = timeout * 1000L;
long expectedMax = expectedMin + 1000L;
context.assertTrue(elapsed >= expectedMin && elapsed <= expectedMax,
String.format("elapsed %d ms is not in the expected range [%d, %d] ms", elapsed, expectedMin, expectedMax));

} catch (MqttException e) {
context.fail(e);
Expand Down