Merged
Conversation
Collaborator
alejouribesanchez
commented
Sep 25, 2024
alejouribesanchez
commented
- Added BankStatement process documents and GET endpoints
- Added AnyDocs process documents and GET endpoints
- Added W2 process documents and GET endpoints
- Added some unit tests
- Added missing PHP types for the functions
- Added support for PHP 8.3
- Update missing unit tests
- Update to version 1.0.4
Added BankStatement process documents and GET endpoints Added AnyDocs process documents and GET endpoints Added W2 process documents and GET endpoints Added some unit tests Added missing PHP types for the functions Added support for PHP 8.3
Update missing unit tests Update to version 1.0.4
manycoding
suggested changes
Sep 25, 2024
Add some links to the official documentation Add missing additional arguments to the GET endpoints
keep pathinfo() is more versatile as it can extract other file path components (like file extension) if needed. Remove file_get_contents() is simpler and reads the entire file at once. It’s easier to use, but can consume more memory for very large files since it loads everything into memory at once
Kaevan89
requested changes
Dec 10, 2024
Collaborator
Kaevan89
left a comment
Kaevan89
left a comment
There was a problem hiding this comment.
Fix GET methods with query parameters.
Split ClientTest.php into multiple focused test classes for documents, checks, bank statements, business cards, line items, tags, and general client functionality. Updated GenerateSignature trait to handle CURLFile and object payloads more robustly. Upgraded phpunit/phpunit to version 12.3.0 in composer.json.
Replaces PHP versions 7.4, 8.0, 8.1, and 8.2 with 8.3 in main.yml and php.yml workflows. Also updates the code coverage commit condition to match PHP 8.3.
Changed all test files to import 'veryfi\Client' instead of 'veryfi\client' to match the correct class name and adhere to PSR standards. This improves consistency and prevents potential autoloading issues.
Migrated phpunit.xml configuration to support PHPUnit 10.x, updating schema location, adding bootstrap and cacheDirectory, and restructuring coverage and source sections for improved test and coverage management.
Introduces ClientCoverageTest to verify initialization and validation of LineItem and LineItemUpdate classes, as well as signature generation in the Client class. Ensures proper exception handling and coverage for various payload types.
Introduces new test methods for processing business cards, checks, and documents using file paths instead of base64. Existing base64 test methods are renamed for clarity. This improves test coverage and distinguishes between file and base64 input scenarios.
Kaevan89
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.