fix: ensure containers are properly attached to specified Docker netw…#23
Merged
Merged
Conversation
…orks The docker_network feature had an issue where containers would sometimes not be on the specified network even though the systemd service had the --network flag. This caused DNS resolution to fail between containers. Improvements: - Create Docker network immediately before service startup (not during initial script setup) to ensure it exists when container is created - Add post-startup verification that container is actually on the specified network - If container isn't on network (e.g., due to timing issues), explicitly connect it using 'docker network connect' - Applied to both install and upgrade scripts This ensures containers on the same docker_network can always reach each other by hostname/service name via Docker's internal DNS. Fixes: Moodle/MariaDB unable to connect despite being on same network https://claude.ai/code/session_01Baxv4zdaJSCbCnQri1J86B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orks
The docker_network feature had an issue where containers would sometimes not be on the specified network even though the systemd service had the --network flag. This caused DNS resolution to fail between containers.
Improvements:
This ensures containers on the same docker_network can always reach each other by hostname/service name via Docker's internal DNS.
Fixes: Moodle/MariaDB unable to connect despite being on same network
https://claude.ai/code/session_01Baxv4zdaJSCbCnQri1J86B
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)