-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deprivatize): scrub private references for public release #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2f0da7c
0ae5800
9531308
9679198
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // mudd.one — Sidebar (tools) | ||
| // Created by M&K (c)2026 VetCoders | ||
| // Created by vetcoders (c)2026 | ||
|
|
||
| import AppKit | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| #!/usr/bin/env bash | ||||||
| # build-dmg.sh — Build mudd.app (Release) + package as DMG | ||||||
| # Supports ad-hoc signing and notarization via vista-build profile | ||||||
| # Created by M&K (c)2026 VetCoders | ||||||
| # Supports ad-hoc signing and notarization via a notarytool keychain profile | ||||||
| # Created by vetcoders (c)2026 | ||||||
| set -euo pipefail | ||||||
|
|
||||||
| REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)" | ||||||
|
|
@@ -16,7 +16,7 @@ BUILD_DIR="${REPO_ROOT}/build" | |||||
| APP_PATH="${BUILD_DIR}/${APP_NAME}.app" | ||||||
| DMG_PATH="${BUILD_DIR}/${DMG_NAME}.dmg" | ||||||
| SIGNING_IDENTITY="${SIGNING_IDENTITY:--}" | ||||||
| NOTARY_PROFILE="${NOTARY_PROFILE:-vista-build}" | ||||||
| NOTARY_PROFILE="${NOTARY_PROFILE:-}" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When
Suggested change
|
||||||
| KEYS_DIR="${HOME}/.keys" | ||||||
|
|
||||||
| echo "=== mudd.one DMG builder ===" | ||||||
|
|
@@ -123,7 +123,7 @@ if [ "${SIGNING_IDENTITY}" != "-" ]; then | |||||
| echo "" | ||||||
| echo "To store notary credentials first:" | ||||||
| echo " xcrun notarytool store-credentials '${NOTARY_PROFILE}' \\" | ||||||
| echo " --key '${KEYS_DIR}/AuthKey_ZT6AXN3759.p8' \\" | ||||||
| echo " --key-id ZT6AXN3759 \\" | ||||||
| echo " --key '${KEYS_DIR}/AuthKey_<YOUR_KEY_ID>.p8' \\" | ||||||
| echo " --key-id <YOUR_KEY_ID> \\" | ||||||
| echo " --issuer <YOUR_ISSUER_ID>" | ||||||
| fi | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a developer runs
make dmg-signedwithout exportingSIGNING_IDENTITY, this now passes the literal placeholderDeveloper ID Application: Your Name (TEAMID)intoscripts/build-dmg.sh. The script treats any value other than-as a real Developer ID and feeds it to the Xcode/codesign signing path, so the target fails with an opaque missing-identity error instead of either using ad-hoc signing or requiring the caller to provide a valid identity.Useful? React with 👍 / 👎.