chore(deprivatize): scrub private references for public release#7
chore(deprivatize): scrub private references for public release#7m-szymanska wants to merge 4 commits into
Conversation
Remove personal names, emails, and private team/machine references from the heartbeat module header. Collapse to neutral Vetcoders attribution per public-release naming convention. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace leaked home path (real OS username) in build guidelines with a neutral placeholder. Genericize private MCP server examples (memex, .ai-memories, sled) into a neutral custom-db / memory example in README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Repo's real remote is github.com/vetcoders/rmcp-mux, but docs/manifest referenced inconsistent private orgs (Loctree, LibraxisAI). Normalize all GitHub URLs (Cargo manifest, CI badge, install script, changelog) to the public vetcoders org. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🤖 Hi @m-szymanska, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @m-szymanska, but I was unable to process your request. Please see the logs for more details. |
There was a problem hiding this comment.
Code Review
This pull request updates repository URLs, ownership details, and installation scripts to reflect the transfer of the project to the vetcoders organization. It also cleans up hardcoded local paths in the developer guidelines and updates the example configurations in the documentation. Feedback was provided on the example configuration in README.md to avoid using tilde (~) expansion in the args and env fields, as the application only expands tildes for socket and status_file paths, which could cause the spawned server to fail.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| args = ["serve", "--config", "config.toml", "--db-path", "~/.local/share/custom-db"] | ||
| env = { DB_PATH = "~/.local/share/custom-db/store" } |
There was a problem hiding this comment.
In the example configuration, ~ is used in the args and env fields (e.g., ~/.local/share/custom-db). However, rmcp-mux only performs tilde (~) expansion on socket and status_file paths (via expand_path in src/config.rs). Since the child process is spawned directly without a shell, any ~ in args or env will be passed literally to the child process and will not be expanded, which can cause the spawned server to fail. It is safer to use absolute paths or placeholders like /path/to/... in the example to avoid misleading users.
| args = ["serve", "--config", "config.toml", "--db-path", "~/.local/share/custom-db"] | |
| env = { DB_PATH = "~/.local/share/custom-db/store" } | |
| args = ["serve", "--config", "config.toml", "--db-path", "/path/to/custom-db"] | |
| env = { DB_PATH = "/path/to/custom-db/store" } |
There was a problem hiding this comment.
Pull request overview
This PR performs a “deprivatize” hygiene pass to prepare rmcp-mux for public release by removing or replacing private org/personal references and updating repository URLs across documentation and metadata.
Changes:
- Updated repository/org URLs in install tooling, README, Cargo metadata, and changelog links.
- Scrubbed author/personal attribution from
src/runtime/heartbeat.rsmodule header. - Generalized developer documentation path examples to remove personal home directory references.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tools/install.sh |
Updates install instructions and repo URL used by cargo install. |
src/runtime/heartbeat.rs |
Replaces private author attribution in module docs. |
README.md |
Updates CI badge/org references and refreshes example configuration snippets. |
docs/dev/guidelines.md |
Replaces a personal absolute path with a generic project-root example. |
CHANGELOG.md |
Rewrites commit links to point at the new GitHub org. |
Cargo.toml |
Updates crate repository URL to the new org. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # rmcp-mux install script | ||
| # Usage: | ||
| # curl -fsSL https://raw.githubusercontent.com/Loctree/rmcp-mux/main/tools/install.sh | sh | ||
| # curl -fsSL https://raw.githubusercontent.com/vetcoders/rmcp-mux/main/tools/install.sh | sh |
| ### One-liner (curl | sh) | ||
| ```bash | ||
| curl -fsSL https://raw.githubusercontent.com/Loctree/rmcp-mux/main/tools/install.sh | sh | ||
| curl -fsSL https://raw.githubusercontent.com/vetcoders/rmcp-mux/main/tools/install.sh | sh |
| [](https://github.com/vetcoders/rmcp-mux/actions/workflows/ci.yml) | ||
| [](https://crates.io/crates/rmcp-mux) | ||
| [](Cargo.toml) |
| "memory": { | ||
| "command": "rmcp-mux-proxy", | ||
| "args": ["--socket", "~/.rmcp-servers/sockets/rmcp-memex.sock"] | ||
| "args": ["--socket", "~/.rmcp-servers/sockets/memory.sock"] | ||
| }, |
| # rmcp-mux – MCP Server Multiplexer | ||
|
|
||
| [](https://github.com/Loctree/rmcp-mux/actions/workflows/ci.yml) | ||
| [](https://github.com/vetcoders/rmcp-mux/actions/workflows/ci.yml) |
CI runs clippy with -D warnings on the latest stable toolchain, which carries lints the code predates (collapsible match arms in wizard/keys.rs; the new manual_checked_ops lint in state.rs). Machine-applicable lints auto-fixed; the guard-then-divide in compute_health_status keeps its scoped allow (a plain 0 default reads clearer than checked_div's Option). Pre-existing, not from the de-privatization scrub. Behaviour unchanged: clippy/fmt clean, tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deprivatize pass for public-release hygiene: scrub private references
(personal names, operator paths, private org/infra fingerprints) per the
cross-repo cleanup.
Verified by a read-only leak audit over tracked files at HEAD: no residual
personal names, operator home paths, host names, tailnet IPs, private
endpoints, or secrets. Brand/product identifiers (vetcoders, loctree, etc.)
intentionally retained.
🤖 Generated with Claude Code