fix(site): align onboarding with make install#9
Conversation
- Rebuild the public landing page from the design handoff as static HTML, CSS, and JS. - Promote make install plus the bare screenscribe command as the user-facing install path. - Keep uv run documented only for source-checkout workflows in the README. - Add verified interactions for copy, mode tabs, accordion, reveal, and responsive hero peeking.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly updates the screenscribe landing page, replacing the uv run commands with a direct make install CLI setup in the README and HTML, and completely redesigning the site with a new stylesheet (landing.css) and interactive JavaScript features in app.js (including a typewriter effect, spotlight, pipeline animation, tabbed modes, and accordions). The reviewer provided several constructive suggestions: fixing a potential race condition in the pipeline animation's setTimeout loops, improving the accordion's accessibility with ARIA attributes, moving hover animations from JavaScript to CSS, and updating the terminal copy button to only copy safe, non-failing installation commands.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ea5b39ca2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add a started flag so the pipeline timer loop can only be initialized once. - Avoid scheduling resume ticks from hover leave before the observer has started the loop. - Addresses PR #9 review comment by gemini-code-assist.
- Link feature accordion buttons to their panels with id and aria-controls. - Hide collapsed panel bodies from assistive technology with hidden and aria-hidden. - Addresses PR #9 review comments by gemini-code-assist and chatgpt-codex-connector.
- Remove JavaScript-only hover listeners for artifact cards. - Express the same hover transform, border, and shadow through CSS. - Addresses PR #9 review comments by gemini-code-assist.
- Replace the decorative demo play button with an aria-hidden span. - Keep the visual play affordance without exposing a dead control to keyboard or screen-reader users. - Addresses PR #9 review comment by chatgpt-codex-connector.
- Limit the install copy button to clone, cd, make install, and config init. - Leave key setup and review commands visible without copying placeholder or demo commands into the clipboard. - Addresses PR #9 review comment by gemini-code-assist.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bd4a41d88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .feature-accordion [data-feat-body] { | ||
| max-height: 0; | ||
| overflow: hidden; | ||
| opacity: 0; |
There was a problem hiding this comment.
When JavaScript is unavailable or fails before wireAccordion() runs, these default styles collapse every feature body while the buttons have no handler to reopen them, so the landing page loses all feature descriptions. Since the page is explicitly implemented as progressive enhancement, leave the panels visible by default and scope the collapsed state to .js/an initialized class so JS can opt into the accordion behavior.
Useful? React with 👍 / 👎.
| <aside><p>ONE COMMAND</p><code><span>$</span> screenscribe review demo.mov</code><small>The report opens in your browser when it's done.</small></aside> | ||
| </article> | ||
|
|
||
| <article class="mode-panel" id="mode-analyze" data-mode-panel="analyze" role="tabpanel" hidden> |
There was a problem hiding this comment.
When JavaScript is disabled or fails before wireModes() attaches handlers, this hidden attribute permanently suppresses the analyze panel while the analyze tab button cannot reveal it, so visitors only see the review-mode copy. For a progressive-enhancement landing page, render both mode descriptions by default and have JS add the hidden state after it has initialized the tab controls.
Useful? React with 👍 / 👎.
| git clone https://github.com/vetcoders/screenscribe.git | ||
| cd screenscribe | ||
| uv sync | ||
| make install |
There was a problem hiding this comment.
This new quickstart command requires make, but the Requirements section immediately above still only tells users to install Python, uv, FFmpeg, and an API key. On Windows or minimal Linux/macOS environments that follow the documented prerequisites exactly, the first setup command now fails with make missing; either add make to the README requirements with install guidance or keep a uv-only fallback in the quickstart.
Useful? React with 👍 / 👎.
1 participant
Summary
make installpath and barescreenscribecommands.uv run screenscribe ...only as source-checkout command-reference guidance.Verification
make -n installmake checkmake brand-scanmake leak-scanmake verifyhttp://127.0.0.1:4173/: desktop 1440x1200 and mobile 390x844, no console/page errors, no horizontal overflow, next-section peek visible, install copy usesmake install, mode tab/accordion/copy interactions pass.Notes
Browser is not available: iab), so browser QA used Playwright against system Chrome instead.