Open
Conversation
JohanHjelsethStorstad
force-pushed
the
chore/auth-filters
branch
from
4d93fd2 to
ed651c0
Compare
Paulijuz
previously approved these changes
Feb 23, 2026
Member
There was a problem hiding this comment.
Looks good to me. This pr adds some essential functionality.
For the future however i think we'll need to look at how the internals of authorizer and service operation are structured because thing are currently out of hand. There are way to many generics and I think people other than you and me will have an extremely hard time to understand it. But this is something which should only be adressed AFTER release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.