Fix "everything 3-phase" mistake & regroup around models#4
Merged
vfinel merged 3 commits intovfinel:developfrom Mar 5, 2026
Merged
Conversation
We always resolved cables to be 3P, whatever the cable :/ It occurred to me that the code was STILL quite difficult to read so I also built a little more on top of the dataclasses to leverage more object-oriented goodness
vperron
commented
Mar 5, 2026
| assert round(total_length[32]) == 1209 | ||
| assert round(total_length[63]) == 68 | ||
| assert round(total_length[125]) == 60 | ||
| assert round(sum(c.length_m for c in cables)) == 2479 |
Collaborator
Author
There was a problem hiding this comment.
to be clear these numbers are for the nodes currently on the colocaion map (that I got the numbers from) which are probably wrong / some loads would have been transferred to other grids / are overestimated, and so on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code is hopefully way clearer now. There might still be bugs 😨