Conversation
It still needs some work but now at least we can point it directly at any sheet (XLSX, ODS, online Google Sheet...)
Points (coordinates) are entered using GPS coordinates Distances are measured accurately by projecting first on the correct CRS metric system. This can "fix" in the magnitude of a few meters per kilometer of cables.
It was the sole place where the code did consider (I suppose) a baseline power of 400V but all the rest supposed V0 = 230V. Also remove useless comments and rename internal variables to make it all clearer
vfinel
reviewed
Mar 7, 2026
| cable.vdrop_volts = cable.resistance * np.max(cable.current_per_phase) | ||
| node.voltage = parent.voltage - cable.vdrop_volts | ||
| node.vdrop_percent = 100 * (V0 - node.voltage) / _vdrop_ref | ||
| node.vdrop_percent = 100 * (V0 - node.voltage) / V0 |
Owner
There was a problem hiding this comment.
oh... interesting... could that explain the differences between calculations and measured values on site... ?! To be continued, I guess
vfinel
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of tiny fixes where I manually went file by file to look for incorrect / incomplete stuff and make the code as clear as possible and adding tests wherever possible !